Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for writing Ion 1.1 null, bool, int, and float binary encoding #612

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

popematt
Copy link
Contributor

Issue #, if available:

None

Description of changes:

  • Adds support for WriteBuffer to write FlexInts and FlexUInts from BigIntegers
  • Adds OpCodes, a class that holds op code constants
  • Adds IonEncoding_1_1, a class that may later be subsumed by a Raw Binary Writer for Ion 1.1. This class contains methods that can write raw Ion values to a WriteBuffer.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 204 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/com/amazon/ion/BufferConfiguration.java 95.00% <ø> (-5.00%) ⬇️
src/com/amazon/ion/IonBufferConfiguration.java 93.54% <100.00%> (-0.21%) ⬇️
src/com/amazon/ion/IonCursor.java 100.00% <100.00%> (ø)
src/com/amazon/ion/OversizedValueException.java 100.00% <100.00%> (ø)
src/com/amazon/ion/Timestamp.java 89.14% <100.00%> (+0.07%) ⬆️
src/com/amazon/ion/impl/IonReaderTextSystemX.java 61.33% <ø> (+1.24%) ⬆️
src/com/amazon/ion/impl/IonReaderTreeUserX.java 92.04% <100.00%> (+5.83%) ⬆️
...c/com/amazon/ion/impl/LocalSymbolTableImports.java 90.62% <ø> (+2.38%) ⬆️
src/com/amazon/ion/impl/_Private_IonConstants.java 25.64% <ø> (ø)
src/com/amazon/ion/impl/bin/WriteBuffer.java 95.69% <100.00%> (+0.16%) ⬆️
... and 14 more

... and 27 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@popematt popematt changed the base branch from master to ion-11-encoding October 25, 2023 18:40
@popematt popematt merged commit b93951a into amazon-ion:ion-11-encoding Oct 25, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants