Migrates IonReaderContinuableTopLevelBinaryTest.java to JUnit 5. #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
approved these changes
Oct 12, 2023
jobarr-amzn
approved these changes
Oct 17, 2023
| * @param bytes the binary Ion data. | ||
| * @return a new reader. | ||
| */ | ||
| private IonReader readerFor(IonReaderBuilder builder, byte[] bytes) { |
There was a problem hiding this comment.
Scrolling back a ways to reach this method, my only quibble in this PR so far is the name of the parameter constructFromBytes. Given a byte[] bytes it seems natural that requested reader would be constructed from it, so requiring a boolean true for this state of affairs seems odd. But it gets weirder when constructFomBytes == false. true I understand, but what will false do?
The documentation for this parameter "whether to construct the reader from bytes or an InputStream" clears that up, but it makes me wonder whether this parameter to be wrapBytesWithInputStream 🤷♂️.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Partially addresses #428 by migrating to JUnit 5 and using
assertThrowsrather than the alternatives.Restructuring the tests to look like the ones in #604 will be done in a future PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.