-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable using Kotlin in Ion Java #488
Conversation
Marking as "ready for review" so that it will run all of the workflows. Not actually ready for review yet. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #488 +/- ##
============================================
- Coverage 67.05% 67.01% -0.05%
+ Complexity 5462 5459 -3
============================================
Files 159 159
Lines 22987 22938 -49
Branches 4117 4113 -4
============================================
- Hits 15415 15371 -44
+ Misses 6295 6291 -4
+ Partials 1277 1276 -1 ☔ View full report in Codecov by Sentry. |
@@ -17,6 +17,7 @@ jobs: | |||
- java: 11 | |||
upload_reports: true | |||
- java: 17 | |||
fail-fast: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If e.g. Java 17 task fails, it won't cancel the Java 11 task. I added it earlier on when we were still using JDK 8 and JDK 11, and there legitimately were reasons why it might fail for one and succeed for the other. I don't know if that's still possible between JDK 11 and JDK 17, but these tasks are relative short (matter of minutes) so if the task is already running why bother cancelling it? Just let it run.
Issue #, if available:
Description of changes:
Changes, grouped by commit:
THIRD_PARTY_LICENSES.md
file for the GitHub repoTHIRD_PARTY_LICENSES.md
file is up-to-date with the actual state of reality.ktlint
is an anti-bikeshedding linter for Kotlin. It's pretty opinionated about unused imports, and apparently it can detect them even in a Java file.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.