Makes the Ion 1.1 text writer write symbol tokens inline by default, instead of using symbol identifiers. #1012
+38
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
I noticed this when implementing macro-aware transcoding. When transcoding from binary, where symbol IDs are generally available, those symbol IDs were being transcoded to text using symbol identifier syntax, e.g.,
$1
. This was due to an incorrect default in the Ion 1.1 text writer builder.After this change, transcoded text Ion 1.1 goes from looking like this:
To this:
These two streams are data model equivalent, but the latter is easier for humans to read. Anyone who wants to see the symbol identifiers in order to get more information about how the symbols would be encoded in binary can enable this using
SymbolInliningStrategy.NEVER_INLINE
, as demonstrated by the added unit test.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.