Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up unexpected interactions between IonSystemBuilder and the reader and writer builders #783

Closed
popematt opened this issue Apr 8, 2024 · 0 comments · Fixed by #802
Closed

Clean up unexpected interactions between IonSystemBuilder and the reader and writer builders #783

popematt opened this issue Apr 8, 2024 · 0 comments · Fixed by #802
Labels
bug cleanup

Comments

@popematt
Copy link
Contributor

popematt commented Apr 8, 2024

  • The default charset for TextWriterBuilder is UTF-8. However, IonSystemBuilder uses ASCII as the charset for its own default TextWriterBuilder.
  • The IonSystemBuilder ignores the catalog of any provided reader builder or writer builder, and in the IonSystemLite constructor, it even asserts that all of the catalogs are the same.

See #781 for some discussion of these issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change IonSystemBuilder's default charset to UTF-8 popematt/ion-java
1 participant
@popematt