Skip to content

Commit

Permalink
Comment asking for more modeling attention in MutableMacroTable
Browse files Browse the repository at this point in the history
  • Loading branch information
jobarr-amzn committed Nov 19, 2024
1 parent eaa4ad3 commit 20f197a
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/main/java/com/amazon/ion/impl/macro/MutableMacroTable.kt
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
// SPDX-License-Identifier: Apache-2.0
package com.amazon.ion.impl.macro

// This needs modeling attention.
// - do we want to model an antecedent chain, or have a flat mutable table?
// - antecedent allows cheap reference to immutable system table or empty table
// - flat mutable table allows simpler implementation, GC of unneeded values, constant number of lookups
// - at some point we'll need the capability to communicate immutable encoding contexts to interpret Ion bytes, but
// this is neither here nor there
class MutableMacroTable(private val antecedent: MacroTable) : MacroTable {
private val macroTable = HashMap<MacroRef, Macro>()

Expand Down

0 comments on commit 20f197a

Please sign in to comment.