Topology refresh changes #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barshaul
force-pushed
the
refresh_topology
branch
from
b83ed5d
to
189010b
Compare
barshaul
force-pushed
the
refresh_topology
branch
from
189010b
to
cf777b0
Compare
nihohit
reviewed
Jul 20, 2023
redis/src/cluster_async/mod.rs
Outdated
| if idx == topology_vec.len() - 1 { | ||
| return Err(e); | ||
| } else { | ||
| continue; |
There was a problem hiding this comment.
so, while we want to use the best view, we're fine with using a view that is held by the minority of nodes?
There was a problem hiding this comment.
If it's the last retry AND we still couldn't find a majority, yes, we will be ok by taking a view with full coverage
barshaul
force-pushed
the
refresh_topology
branch
3 times, most recently
from
744ab15
to
fbbb9df
Compare
|
@nihohit Finished first round |
nihohit
reviewed
Jul 24, 2023
nihohit
reviewed
Jul 24, 2023
barshaul
force-pushed
the
refresh_topology
branch
2 times, most recently
from
adba2d6
to
24475ae
Compare
barshaul
commented
Jul 26, 2023
|
@nihohit Ready for review: two last commits, addressing your last comments and added retries. |
nihohit
reviewed
Jul 30, 2023
| Ok(()) | ||
| } | ||
| } | ||
|
|
||
| // Query a node to discover slot-> master mappings | ||
| async fn refresh_slots(inner: Arc<InnerCore<C>>, curr_retry: usize) -> RedisResult<()> { |
There was a problem hiding this comment.
sadly, the diff isn't there. Did something change in the logic here?
There was a problem hiding this comment.
nope, only changed it to get curr_retry: usize instead of AtomicUsize
barshaul
force-pushed
the
refresh_topology
branch
from
6c63afa
to
6384fcd
Compare
|
@nihohit round |
barshaul
force-pushed
the
refresh_topology
branch
2 times, most recently
from
1bf7465
to
2f71bcd
Compare
barshaul
force-pushed
the
refresh_topology
branch
from
2f71bcd
to
45db032
Compare
barshaul
force-pushed
the
refresh_topology
branch
from
45db032
to
48cf685
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed refresh_slots to run with retries and query multiple nodes and return the most frequent topology.