SlotMap refactor - Added NodesMap, Update the slot map upon MOVED errors #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rd nodes and slot map values. (#185) * SlotMap refactor: Added new NodesMap, changed shard addresses to be shard between shard nodes and slot map values
barshaul
force-pushed
the
update_slotmap_moved
branch
2 times, most recently
from
eafaadb
to
368283b
Compare
asafpamzn
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request combines the changes from PRs #186 and #185 into the main branch. It introduces two significant updates:
SlotMap Refactor: The SlotMap structure has been updated with the addition of a
NodesMap, which allows shard addresses to be shared between shard nodes and slot map values. This refactor optimizes how shard information is managed. For a detailed explanation, refer to PR SlotMap refactor: Added NodesMap, sharing shard addresses between shard nodes and slot map values. #185.The diagram on the left illustrates the current SlotMap design, while the diagram on the right shows the newly implemented structure:
MOVED Error Handling: Logic has been added to update the slot map in response to
MOVEDerrors. Previously, this was handled only during refresh_slots operations. With this change, the slot map is updated immediately upon encountering aMOVEDerror. More information can be found in PR Added logic to update the slot map based on MOVED errors #186.