Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle PubSub commands routing #176

Merged
merged 8 commits into from
Jul 29, 2024

Conversation

shohamazon
Copy link
Member

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shohamazon shohamazon requested a review from ikolomi July 28, 2024 14:56
while let Some(key) = iter.next() {
if let Value::BulkString(key_bytes) = key {
if let Some(Value::Int(value)) = iter.next() {
let key_str = String::from_utf8_lossy(&key_bytes);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not to use Vec instead of strings

Signed-off-by: shohame <[email protected]>
@shohamazon shohamazon merged commit de53b2b into amazon-contributing:main Jul 29, 2024
10 checks passed
@shohamazon shohamazon deleted the pubsub branch July 29, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants