Add binary support #172
Merged
Add binary support #172
+91
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avifenesh
force-pushed
the
cluster_scan/bunary_support
branch
2 times, most recently
from
25060da
to
4622d98
Compare
avifenesh
force-pushed
the
cluster_scan/bunary_support
branch
from
4622d98
to
a5436e1
Compare
eifrah-aws
reviewed
Jul 7, 2024
redis/src/cluster_async/mod.rs
Outdated
| @@ -139,16 +139,16 @@ where | |||
| }) | |||
| } | |||
|
|
|||
| // Special handling for `SCAN` command, using cluster_scan | |||
| /// Special handling for `SCAN` command, using cluster_scan. | |||
| @@ -487,7 +487,7 @@ where | |||
| async fn send_scan<C>( | |||
| scan_state: &ScanState, | |||
| core: &C, | |||
| match_pattern: Option<String>, | |||
| match_pattern: Option<Vec<u8>>, | |||
There was a problem hiding this comment.
BytesMut is more efficient, any special reason why you choose Vec<u8> ? (BytesMut is similar to Vec<u8> but with less copies and allocations)
There was a problem hiding this comment.
The built in function of the library is to_redis_args which return Vec
There was a problem hiding this comment.
Might be better to refactor but not at this point
There was a problem hiding this comment.
Makes sense not to make a drastic change at this point
avifenesh
force-pushed
the
cluster_scan/bunary_support
branch
from
a5436e1
to
789f324
Compare
eifrah-aws
approved these changes
Jul 7, 2024
eifrah-aws
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.