Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to refresh_connections only if failed_conn isn't empty #170

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

barshaul
Copy link

@barshaul barshaul commented Jul 3, 2024

ATM refresh connections is being called from each periodic check even when no failed connections were found which resulting in a lot of logs like:

�[2m2024-07-03T17:07:12.769490Z�[0m �[32m INFO�[0m �[2mredis::cluster_async�[0m�[2m:�[0m Started refreshing connections to []
�[2m2024-07-03T17:07:12.769523Z�[0m �[32m INFO�[0m �[2mredis::cluster_async�[0m�[2m:�[0m refresh connections completed
�[2m2024-07-03T17:07:14.331242Z�[0m �[32m INFO�[0m �[2mredis::cluster_async�[0m�[2m:�[0m Started refreshing connections to []
�[2m2024-07-03T17:07:14.331271Z�[0m �[32m INFO�[0m �[2mredis::cluster_async�[0m�[2m:�[0m refresh connections completed
�[2m2024-07-03T17:08:12.771693Z�[0m �[32m INFO�[0m �[2mredis::cluster_async�[0m�[2m:�[0m Started refreshing connections to []
�[2m2024-07-03T17:08:12.771726Z�[0m �[32m INFO�[0m �[2mredis::cluster_async�[0m�[2m:�[0m refresh connections completed

@barshaul barshaul requested a review from avifenesh July 3, 2024 17:34
@avifenesh
Copy link
Member

LGTM

@barshaul barshaul merged commit b954618 into amazon-contributing:main Jul 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants