Added gatemate_a1_evb board #249
Conversation
|
The Pull Request failed because it doesn't recognize 'GateMatePlatform' import because I made a separate Pull Request for that in 'amaranth-lang' |
This is normal. We don't really have a process for introducing a new platform since it's just going to keep failing until a new Amaranth release is made. |
amaranth_boards/gatemate_a1_evb.py
Outdated
| overrides = dict(yosys_opts="-p 'synth_gatemate -top {} -nomx8 -vlog'".format(name), | ||
| pr_opts="-v -ccP", |
There was a problem hiding this comment.
While these could and should be valid overrides in principle, they currently aren't: you are not doing anything with yosys_opts or pr_opts in your Amaranth PR. In addition, basic options like this should not be in a board file at all.
There was a problem hiding this comment.
Should I remove toolchain_prepare ?
There was a problem hiding this comment.
I can't see a reason why one would be needed here.
amaranth_boards/gatemate_a1_evb.py
Outdated
| @property | ||
| def required_tools(self): | ||
| return super().required_tools + [ | ||
| "openFPGALoader" |
There was a problem hiding this comment.
Although it's not currently documented, required_tools is only for the tools required to produce the bitstream. Programming tools should not included and it will cause issues if they are.
There was a problem hiding this comment.
I will remove that, but just to point out that ulx3s.py has the same line aswell.
There was a problem hiding this comment.
Yes, that's also wrong (I missed it during review previously).
amaranth_boards/gatemate_a1_evb.py
Outdated
| def toolchain_prepare(self, fragment, name, **kwargs): | ||
| overrides = dict(yosys_opts="-p 'synth_gatemate -top {} -nomx8 -vlog'".format(name), | ||
| pr_opts="-v -ccP", | ||
| openfpgaloader_opts="-b gatemate_evb_jtag --cable dirtyJtag") |
There was a problem hiding this comment.
Since overrides only affect the build process, not the programming process, this option will never be used.
amaranth_boards/gatemate_a1_evb.py
Outdated
| pr_opts="-v -ccP", | ||
| openfpgaloader_opts="-b gatemate_evb_jtag --cable dirtyJtag") | ||
| overrides.update(kwargs) | ||
| return super().toolchain_prepare(fragment, name, **overrides) |
There was a problem hiding this comment.
(In this particular case I don't think you need any toolchain overrides.)
amaranth_boards/gatemate_a1_evb.py
Outdated
| Subsignal("cs", Pins("IO_EA_B3", dir ="o" )), | ||
| ), | ||
|
|
||
| Resource("pmod", 0, |
There was a problem hiding this comment.
This is definitely a Connector.
There was a problem hiding this comment.
Changed from Resource to Connector
|
|
||
|
|
||
| # Mostly used for RP2040 | ||
| Resource("gpio", 0, |
There was a problem hiding this comment.
This also looks like a Connector.
There was a problem hiding this comment.
This is used for RP2040, and there are no external connections to these pins here. Are they still connectors?
There was a problem hiding this comment.
The point of a Connector isn't necessarily that it's a physical connector, but that it's an extension point where a downstream user of this platform can attach project specific resources. A project using SPI to communicate with the RP2040 could e.g. want to attach a SPIResource to some of those signals.
amaranth_boards/gatemate_a1_evb.py
Outdated
| class GateMate_A1_EVB(_GateMate_A1_EVB): | ||
| name = "Olimex GateMateA1-EVB" |
There was a problem hiding this comment.
| class GateMate_A1_EVB(_GateMate_A1_EVB): | |
| name = "Olimex GateMateA1-EVB" |
Hello
I opened up a pull request also on
amaranth-langfor GateMate, I opened it up here because thegatemate_a1_evb.pyfile is present inamaranth-boardsfolder.I used
openFPGALoaderfor programming and added the programming in thegatemate_a1_evb.pyfile.The constraint file is written by me, I went through the documentation and placed the appropriate pins with their names. There could be some mistakes, I checked it many times.