Add ToErrorOrAsync extension method #122
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my current project, we are using a
ToErrorOrAsync
extension method to createErrorOr
-objects from async calls. We mainly use this to add conditions to database calls, allowing us to concisely check the returned value and define errors for non-matching return values.Example:
This can be solved by awaiting the call first, either by storing it in a variable (
User? user = await userRepository.FindById(id); return user.ToErrorOr()...
) or wrapping the call in brackets (return (await ...).ToErrorOr()...
), but - at least for us - this extension method is preferred. The method works well with the existingTask<ErrorOr<T>>
-overloads that have recently been added for the other methods (FailIf
,Then
, ...).If you think this might be a good addition for this library, I'd be happy to get this merged and add changes if necessary.