Zarik staging #2450
Merged
Zarik staging #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c08e67e.
The-personified-devil
approved these changes
Oct 9, 2024
|
Possibly #2446 but i cannot reproduce and i don't have any evidence that downgrading fixes the issue. In any case i remember having issues upgrading only wgpu because egui 0.28 would complain |
|
If it's tied to egui, then sure, it's fine |
|
Tbh we could've only downgraded wgpu for the dash and not for the client, but doesn't really matter |
|
Apparently it's not a good idea. wgpu often relies on pinning versions of web-sys, and if it's not that, some other dependencies make it impossible to build two versions together. This is actually the reason why egui should be updated in lockstep with wgpu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undoing the dependencies bump because egui is bugged. Also downgrading wgpu because of another reported crash.