chore(ci): replace deprecated toolchain action #2205
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-personified-devil
force-pushed
the
actions-update
branch
2 times, most recently
from
863858d
to
af4be71
Compare
The-personified-devil
force-pushed
the
actions-update
branch
from
af4be71
to
091b5a1
Compare
|
Why is this PR draft? |
zmerp
requested changes
Jun 26, 2024
| override: true | ||
| - uses: Swatinem/rust-cache@v1 | ||
| - uses: actions/checkout@v4 | ||
| - uses: dtolnay/[email protected] |
There was a problem hiding this comment.
I'd say not to download the toolchain for the current msrv. It's going to be done by xtask and I want the version to be pulled dynamically from the root Cargo.toml.
There was a problem hiding this comment.
Yea this was only an attempt to fix cargo-msrv
There's complete replacements that also solve the clippy issue, so I want to use them instead, see discord for reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would also allow us to directly specify a version of rust that we want