Skip to content

fix(client_openxr): 🐛 Try fixing crash on Quest 2 related to multimodal #4695

fix(client_openxr): 🐛 Try fixing crash on Quest 2 related to multimodal

fix(client_openxr): 🐛 Try fixing crash on Quest 2 related to multimodal #4695

Triggered via pull request January 19, 2025 16:08
Status Success
Total duration 6m 37s
Artifacts

rust.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

4 warnings
check-windows: alvr/graphics/src/stream.rs#L227
warning: unsafe function's docs are missing a `# Safety` section --> alvr\graphics\src\stream.rs:227:5 | 227 | pub unsafe fn render(&self, hardware_buffer: *mut c_void, view_params: [StreamViewParams; 2]) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc = note: `#[warn(clippy::missing_safety_doc)]` on by default
check-windows: alvr/client_openxr/src/interaction.rs#L233
warning: this expression creates a reference which is immediately dereferenced by the compiler --> alvr\client_openxr\src\interaction.rs:233:53 | 233 | MultimodalMeta::new(xr_session.clone(), &extra_extensions, xr_system) | ^^^^^^^^^^^^^^^^^ help: change this to: `extra_extensions` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
check-linux: alvr/graphics/src/stream.rs#L227
warning: unsafe function's docs are missing a `# Safety` section --> alvr/graphics/src/stream.rs:227:5 | 227 | pub unsafe fn render(&self, hardware_buffer: *mut c_void, view_params: [StreamViewParams; 2]) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc = note: `#[warn(clippy::missing_safety_doc)]` on by default
check-linux: alvr/client_openxr/src/interaction.rs#L233
warning: this expression creates a reference which is immediately dereferenced by the compiler --> alvr/client_openxr/src/interaction.rs:233:53 | 233 | MultimodalMeta::new(xr_session.clone(), &extra_extensions, xr_system) | ^^^^^^^^^^^^^^^^^ help: change this to: `extra_extensions` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default