Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): publish packages #64

Merged
merged 2 commits into from
Oct 8, 2024
Merged

chore(release): publish packages #64

merged 2 commits into from
Oct 8, 2024

Conversation

naipaka
Copy link
Contributor

@naipaka naipaka commented Oct 8, 2024

@@ -118,6 +118,7 @@ CustomScrollView(
### avoid_hardcoded_color

Do not use hard-coded Color.
However, `Colors.transparent` can be used.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in this comment, I thought it would be kind to add an explanation, so I added it!

@naipaka naipaka marked this pull request as ready for review October 8, 2024 00:16
@naipaka naipaka requested a review from a team as a code owner October 8, 2024 00:16
@naipaka naipaka requested review from boywithdv and removed request for a team October 8, 2024 00:16
Copy link
Member

@riscait riscait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you for update!

Copy link
Contributor

@boywithdv boywithdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naipaka naipaka merged commit 7012713 into main Oct 8, 2024
1 check passed
@naipaka naipaka deleted the release branch October 8, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants