Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #21

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Revert #21

wants to merge 4 commits into from

Conversation

zahaaMuhanna
Copy link
Contributor

No description provided.

@Palimenia
Copy link
Collaborator

@zahaaMuhanna Please add comments to the PR explaining what changes were made.

@zahaaMuhanna
Copy link
Contributor Author

1- ignore the changes in the translation folder. (I tried adding an alert in the first but removed it).
2- The popup.js file has initToggle function now only handles storing the on/off state of the extension and directly triggers a page reload using chrome.tabs.reload when the toggle is switched, whether on or off. In contrast, revert.js will return all replaced words to their original words when the page reloads after toggling off the switch.

@zahaaMuhanna
Copy link
Contributor Author

The revert branch also have the underline changing, u can ignore the changing for these feature, and just take the implement the revert

@zahaaMuhanna
Copy link
Contributor Author

for the revert feature, we have a small issue, and we want to make another testing on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zahaaMuhanna @Palimenia