Feature: Add tabs and footer #137
Conversation
… some tests to allow for responsive changes to version display.
… breaks the compiling of the template
stephenoldham
changed the title
There was a problem hiding this comment.
Nice one, just a couple of comments
We kind of need to make a decision around whether we want to lean on Edge.js templating a bit more or not (eg. for hiding work in progress features in production builds), will affect #136 as well
| :href="isLatest ? '#' : 'https://github.com/alpinejs/alpine/releases'" | ||
| x-text="detected" | ||
| ></a> | ||
| <span x-text="loadingText"></span> |
There was a problem hiding this comment.
Should we move this loading state to display inside the panel? I think it's fine here, but maybe there's a more obvious spot for it.
There was a problem hiding this comment.
Thought I'd have a play with some animation...too much?
Updated Version
If we are into this...this version is a bit better with a mono font below.
There was a problem hiding this comment.
I like it...
too much?
Probably :) I'm personally okay with it though.
There was a problem hiding this comment.
I mean...it is a little too much really 😆
Just the text with a blinking cursor in the components panel might be the one.
There was a problem hiding this comment.
I'm probably not the best person to judge. Maybe let Hugo or Ryan chime in.
There was a problem hiding this comment.
Haha @stephenoldham let's go for blinking text
I guess we can always add a nicer animation down the line
…n favour of x-show
…ronment. Flag is now passed in when compiling the views in render.js
Co-authored-by: Kevin Batdorf <[email protected]>
Co-authored-by: Kevin Batdorf <[email protected]>
Co-authored-by: Kevin Batdorf <[email protected]>
Co-authored-by: Kevin Batdorf <[email protected]>
|
@stephenoldham @KevinBatdorf shall we merge this? We can improve the loading state later, this would mean @ryangjchandler's events tab PR can get moved on and so can #126 |
|
Were we just waiting on animations? Can merge now and do that separately anyway. |
I believe so, I've taken this for a spin again and it all looks good (+ tests are passing) so should be safe to merge. |
|
Sorry guys, in the throws of break/back to work. Yeah loading animation can wait 👍🏼 |
Adds new header/footer layout and content. Also adds new tabs functionality, not currently enabled when using the panel in production.
Removed edge files from prettier format run because using the html parser breaks components and includes based on incorrect formatting of tags.