Add workflow to allow creating image from this branch #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syed-ali-tw
force-pushed
the
mongo-to-pg-workflow-changes
branch
from
ecd5d0c to
4e48c79
Compare
dj-maisy
reviewed
Jan 24, 2025
syed-ali-tw
force-pushed
the
mongo-to-pg-workflow-changes
branch
from
4e48c79 to
1edda29
Compare
dj-maisy
requested changes
Jan 24, 2025
Comment on lines
19
to
25
| ecrRepositoryName: | ||
| description: 'ECR repo name to push image to' | ||
| required: true | ||
| type: choice | ||
| options: | ||
| - publisher-on-postgres-branch | ||
| default: 'publisher-on-postgres-branch' |
There was a problem hiding this comment.
Suggested change
| ecrRepositoryName: | |
| description: 'ECR repo name to push image to' | |
| required: true | |
| type: choice | |
| options: | |
| - publisher-on-postgres-branch | |
| default: 'publisher-on-postgres-branch' |
As there's only one ECR Repo that you intend to target, I'd consider removing this option.
| uses: alphagov/govuk-infrastructure/.github/workflows/build-and-push-multiarch-image.yml@main | ||
| with: | ||
| gitRef: ${{ inputs.gitRef || github.event.release.tag_name }} | ||
| ecrRepositoryName: ${{ inputs.ecrRepositoryName }} |
There was a problem hiding this comment.
Suggested change
| ecrRepositoryName: ${{ inputs.ecrRepositoryName }} | |
| ecrRepositoryName: publisher-on-postgres-branch |
...and hardcode this instead.
syed-ali-tw
force-pushed
the
mongo-to-pg-workflow-changes
branch
from
1edda29 to
3312083
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add workflow to allow creating image from this branch
Follow these steps if you are doing a Rails upgrade.