Switch to @prettier/sync
for sync Nunjucks formatting
#3971
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prettier recently switched to a Promise-based API which affects Nunjucks macro options
format()
Prettier 3.0: Hello, ECMAScript Modules!
https://prettier.io/blog/2023/07/05/3.0.0.html
We'd need to replace Nunjucks
for
loops withasyncEach
to giveinclude
blocks asynchronous support so we held the Review app onprettier@2
for now:But this PR now takes the advice from the blog article above:
With thanks to @fisker we can continue using
tsc
and our ESLint plugins: