Move logs from govuk-aws #119
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsimpson1
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Mostly looks good, the imports will fail in non-prod environments, though I guess that won't be much of an issue if you're planning on manually updating the imports file for each environment.
I've made some small suggestions, if you want to do the import now they can be fixed later.
logs/integration.govuk.backend
Outdated
logs/main.tf
Outdated
|
|
||
| resource "aws_iam_policy" "logs_writer" { | ||
| name = "fastly-logs-${var.environment}-logs-writer-policy" | ||
| policy = <<EOF |
There was a problem hiding this comment.
These IAM policies should use aws_iam_policy_document
logs/main_imports.tf
Outdated
There was a problem hiding this comment.
The imports that refer to prod won't work in the other environments
MuriloDalRi
force-pushed
the
logs-production
branch
from
de7737b to
1e2034e
Compare
Move the infra-fastly-logs project from govuk-aws.
MuriloDalRi
force-pushed
the
logs-production
branch
from
1e2034e to
253dd60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the infra-fastly-logs project from govuk-aws.
alphagov/govuk-infrastructure#1127