Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "disable autocomplete" feature flag #3624

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Remove "disable autocomplete" feature flag #3624

merged 1 commit into from
Jan 10, 2025

Conversation

csutter
Copy link
Contributor

@csutter csutter commented Jan 8, 2025

We are centralising the enabling/disabling of autocomplete in Search API v2 so we don't need individual feature flags across several apps.

  • Use search_with_autocomplete component directly
  • Remove ApplicationHelper#search_component

Depends on: alphagov/search-api-v2#375

We are centralising the enabling/disabling of autocomplete in Search API
v2 so we don't need individual feature flags across several apps.

- Use search_with_autocomplete component directly
- Remove ApplicationHelper#search_component
@csutter csutter added the do-not-merge Indicates that a PR should not be merged into master / release branches label Jan 8, 2025
@govuk-ci govuk-ci temporarily deployed to finder-frontend-pr-3624 January 8, 2025 11:46 Inactive
@csutter csutter requested a review from kevindew January 8, 2025 15:13
Copy link
Member

@kevindew kevindew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

@csutter csutter merged commit c8d505f into main Jan 10, 2025
13 checks passed
@csutter csutter deleted the remove-ac-ff branch January 10, 2025 14:25
@csutter csutter removed the do-not-merge Indicates that a PR should not be merged into master / release branches label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants