Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve print styles for right-to-left (RTL) content #3835

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

matthillco
Copy link
Contributor

@matthillco matthillco commented Nov 4, 2024

What

Improve print styles for right-to-left (RTL) content:

  • Force world_location_news layout to print full width.
  • Enable RTL rendering for breadcrumbs and header

Note: While the heading has now been flipped to read right-to-left in RTL mode, the layout remains the same: the heading is on the left of the screen with the language switch on the right. This follows the pattern set out on other pages, where the columns remain in their original direction.

This is part of the work to improve print styles more generally. Trello

Note: This is a dependency of alphagov/government-frontend#3404

Why

The components should render in the intended direction for RTL languages.

Visual Changes

Full width layouts

Before After
image image

Breadcrumbs & Header

Before After
image image

@govuk-ci govuk-ci temporarily deployed to collections-pr-3835 November 4, 2024 16:53 Inactive
@matthillco matthillco changed the title Improve print styles for page templates and better RTL printing Improve print styles for right-to-left (RTL) content Nov 4, 2024
@matthillco matthillco marked this pull request as draft November 5, 2024 14:38
@matthillco matthillco marked this pull request as ready for review January 16, 2025 17:19
Copy link
Contributor

@AshGDS AshGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matthillco matthillco merged commit c7c7b02 into main Jan 17, 2025
14 checks passed
@matthillco matthillco deleted the rtl-print-styles branch January 17, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants