Merge pull request #3807 from alphagov/fix-invalid-html-world-locations

Fix markup for world-locations section
alphagov · Oct 24, 2024 · 7fe5d5d · 7fe5d5d
2 parents 4879178 + 05b3fe7
commit 7fe5d5d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/app/assets/stylesheets/views/_world_index.scss b/app/assets/stylesheets/views/_world_index.scss
@@ -6,6 +6,7 @@
   }
 
   .world-locations-groups {
+    list-style-type: none;
     padding: govuk-spacing(5) 0 0;
   }
 

diff --git a/app/views/world/index.html.erb b/app/views/world/index.html.erb
@@ -60,7 +60,7 @@
           data-ga4-track-links-only
           data-ga4-link="<%= { event_name: "navigation", type: "filter" }.to_json %>">
           <% @presented_index.grouped_world_locations.each do |letter, locations| %>
-            <div class="world-locations-group" data-filter="inner-block">
+            <li class="world-locations-group" data-filter="inner-block">
               <h3 class="world-locations-group__letter"><%= letter %></h3>
               <ol class="world-locations-group__list">
                 <% locations.each do |location| %>
@@ -69,7 +69,7 @@
                   </li>
                 <% end %>
               </ol>
-            </div>
+            </li>
           <% end %>
         </ol>
       </div>
@@ -96,15 +96,15 @@
 
       <div class="govuk-grid-column-two-thirds">
         <ol class="world-locations-groups">
-          <div class="world-locations-group">
+          <li class="world-locations-group">
             <ol class="world-locations-group__list">
               <% @presented_index.international_delegations.each do |delegation| %>
                 <li class="world_locations-group__item" data-filter="item" data-filter-terms="<%= @presented_index.filter_terms(delegation) %>">
                   <%= @presented_index.world_location_link(delegation) %>
                 </li>
               <% end %>
             </ol>
-          </div>
+          </li>
         </ol>
       </div>
     </section>
-Original file line number
+Diff line change
@@ Expand Up / @@ -6,6 +6,7 @@ @@
       }
       .world-locations-groups {
+        list-style-type: none;
         padding: govuk-spacing(5) 0 0;
       }
@@ Expand Down @@