Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable bank for CAD #209

Merged
merged 3 commits into from
Jan 23, 2023
Merged

Disable bank for CAD #209

merged 3 commits into from
Jan 23, 2023

Conversation

jonahbron
Copy link
Contributor

As a temporary solution to avoid confusing users, bank account options are explicitly disabled if they select their country of residence as being in Canada. More work will need to be done to support bank payments in Canada as they do not use ACH.

https://stripe.com/docs/payments/acss-debit

#208

Created an awu-login-link component to prompt the user for an interface.
Fixed the login-link worker to run in the worker environment properly
(jsonwebtoken doesn't work).  Wired up and verified to work correctly.
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 21, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8d7aec4
Status: ✅  Deploy successful!
Preview URL: https://f89b3d53.alphabetworkersunion.pages.dev
Branch Preview URL: https://disable-bank-cad.alphabetworkersunion.pages.dev

View logs

Rolled back Node version to one supported by Cloudflare.
frontend/content/login.en.md Show resolved Hide resolved
frontend/src/element/signup.ts Outdated Show resolved Hide resolved
frontend/src/element/signup.ts Outdated Show resolved Hide resolved
@undefinedseance
Copy link
Contributor

I think it might be more clear to remove the payment option pills rather than gray them out (since they don't go grey in-frame when I switch to Canada, at least for me on my laptop)
image

but this is obv waaay better than what is there now, lgtm ship it imo

@jonahbron jonahbron merged commit ad88aea into main Jan 23, 2023
@jonahbron jonahbron deleted the disable-bank-cad branch January 23, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants