Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading peer certificates for corporate networks #83

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

revblock
Copy link
Contributor

Currently when running SVM on a corporate style network that uses a peer certificate you will get an error because it won't automatically be recognised. The error looks like this

./svm list
Error: error sending request for url (https://github.com/roynalnaruto/solc-builds/raw/240988f6e5de44fd182a9d4446a838cb7b7166db/macosx/aarch64/list.json): error trying to connect: invalid peer certificate contents: invalid peer certificate: UnknownIssuer

Caused by:
    0: error trying to connect: invalid peer certificate contents: invalid peer certificate: UnknownIssuer
    1: invalid peer certificate contents: invalid peer certificate: UnknownIssuer

This PR includes the rustls-tls-native-roots feature in reqwest so that peer certificates can be included which will prevent the error.

This is my first PR on this repo and I'm fairly new to rust so please let me know if I've missed anything, thanks.

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we also have this on foundry

@DaniPopes DaniPopes merged commit 4d33b7e into alloy-rs:master Feb 7, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants