Eliminate "text file busy" errors

[smoelius]

While running some tests involving Foundry, I have encountered "text file busy" errors, like described in #16.

This PR is currently organized as two commits:

• Add can_install_while_solc_is_running test - intentionally fails with "text file busy"
• Eliminate "test file busy" errors - installs solc to a temporary file and then renames it, so that the previous test passes

Nits are welcome.

EDIT: I'll be happy to fix the typo in the commit message, once you've had a chance to review. Fixed.

[mattsse]

lgtm, pending @DaniPopes

[mattsse]

ah okay, all this does is write to a new tmp file and then move it to the correct location?

[smoelius]

Actually, that just unpacks the NamedTempFile into a File and a TempPath.

The renaming occurs here:

svm-rs/crates/svm-rs/src/install.rs

Line 175 in 4c3867e

temp_path.persist(&solc_path)?;

Some additional context:

• https://docs.rs/tempfile/latest/src/tempfile/file/mod.rs.html#203-218
• https://docs.rs/tempfile/latest/src/tempfile/file/imp/unix.rs.html#112-144

[smoelius]

FYI, I'm going to try to fix the Windows failure.

[smoelius]

There were two Windows problems:

• The new test must use where (not which) to find sleep.
• Apparently, Windows does not allow a file to be renamed to a path that is opened. So the file at solc_path must be renamed before the new file can be renamed to solc_path.

Both of these should be fixed now.

[mattsse]

clippy unrelated

[smoelius]

Thanks!

[mattsse]

thank you 🫡