Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): CLI refactor #102

Merged
merged 8 commits into from
Dec 20, 2023
Merged

feat(cli): CLI refactor #102

merged 8 commits into from
Dec 20, 2023

Conversation

Evalir
Copy link
Collaborator

@Evalir Evalir commented Dec 1, 2023 •
edited
Loading

Refactors the CLI code to using the cmd.run(args) pattern we use in foundry. Functionality is preserved.

@Evalir Evalir marked this pull request as ready for review December 14, 2023 17:24
@Evalir Evalir changed the title [WIP] feat(cli): CLI refactor feat(cli): CLI refactor Dec 14, 2023
mattsse
mattsse approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crates/svm-rs/src/bin/svm-bin/usev.rs Outdated Show resolved Hide resolved
@Evalir Evalir merged commit cbf4c3c into master Dec 20, 2023
5 checks passed
@Evalir Evalir deleted the evalir/misc-refactor branch December 20, 2023 16:47
@mattsse mattsse mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@roynalnaruto roynalnaruto Awaiting requested review from roynalnaruto

@onbjerg onbjerg Awaiting requested review from onbjerg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Evalir @mattsse