Create strings.xml #203
Open
Create strings.xml #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristy-hu
changed the title
| <string name="language_sk">Slovák</string> | ||
| <string name="language_es">Español</string> | ||
| <string name="language_tr">Türkçe</string> | ||
| <string name="language_zh-cn">简体中文</string> |
There was a problem hiding this comment.
CI is unhappy because this name is invalid, how about language_zh_cn instead?
There was a problem hiding this comment.
language_zh_cn is perfectly fine!
There was a problem hiding this comment.
Any chance I could hop on this? Thinking of forking @Kristie-Hu 's fork to make any necessary final edits, if they're not available atm!
There was a problem hiding this comment.
It's been while... I'm not sure the app is currently still under maintenance, but maybe @wli-linda, you can help identify any issue with the xml, if you are free at the moment. :)
But actually looking back, I'd say language_zhCN might be a lot better than language_zh_cn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create strings.xml for Simplified Chinese