Updated README for geoip-redirect package #1418
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOrangePuff
requested changes
Jan 5, 2025
packages/geoip-redirect/README.md
Outdated
| When defining the Lambda@Edge function, this construct serves one default host to redirect too: | ||
| ``` | ||
| define: { | ||
| "process.env.REDIRECT_HOST": options.redirectHost, |
There was a problem hiding this comment.
Minor point but the formatting looks a bit funky here
|
Merged Finn's branch and logic into README. Added diagram 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
README updated with:
Screenshots (if applicable)
Other solutions considered (if any)
Notes to PR author
Notes to reviewers