Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerender cdk v2 hotfixes #1260

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Prerender cdk v2 hotfixes #1260

merged 4 commits into from
Dec 6, 2023

Conversation

AdamJHall
Copy link
Contributor

Description of the proposed changes
This PR fixes a couple of issues:

  1. Unable to passthrough required props to Lambda functions when using the PrerenderLambda construct
  2. Esbuild fails for lambda functions due to not being wrapped in json.stringify
  3. Cannot use a real VPC object when passing to the PrerenderFargate construct as all references to the vpcId MUST be a string and cannot be a ref

Notes to PR author

⚠️ Please make sure the changes adhere to the guidelines mentioned here

Notes to reviewers

🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

Copy link
Contributor

@TheOrangePuff TheOrangePuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdamJHall AdamJHall merged commit 54f080a into main Dec 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants