Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-1072: Assign distribution as class property #1143

Merged
merged 2 commits into from
Oct 26, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/static-hosting/lib/static-hosting.ts
Original file line number Diff line number Diff line change
Expand Up @@ -383,10 +383,11 @@
errorResponses: props.enableErrorConfig ? errorResponses : [],
};

const distribution = new Distribution(this, "BucketCdn", distributionProps);
this.distribution = new Distribution(this, "BucketCdn", distributionProps);

if (props.overrideLogicalId) {
const cfnDistribution = distribution.node.defaultChild as CfnDistribution;
const cfnDistribution = this.distribution.node
.defaultChild as CfnDistribution;
cfnDistribution.overrideLogicalId(props.overrideLogicalId);
}

Expand All @@ -403,7 +404,7 @@
],
});

const cloudFrontInvalidationPolicy = new Policy(

Check warning on line 407 in packages/static-hosting/lib/static-hosting.ts

View workflow job for this annotation

GitHub Actions / build

'cloudFrontInvalidationPolicy' is assigned a value but never used. Allowed unused vars must match /^_/u
this,
"CloudFrontInvalidationPolicy",
{
Expand Down
Loading