Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom nodes #49

Merged
merged 10 commits into from
Dec 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: Continuous Integration

on:
- pull_request

jobs:
docs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3

- name: Setup TeX Live
uses: teatimeguest/setup-texlive-action@v3
with:
package-file: |
ci/texlive/texlive_packages
- name: Sphinx Action
uses: ammaraskar/sphinx-action@master
with:
docs-folder: "."
7 changes: 6 additions & 1 deletion .readthedocs.yml → .readthedocs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@
# Required
version: 2

# Set the version of Python and other tools you might need
build:
os: ubuntu-22.04
tools:
python: "3.11"

# Build documentation in the docs/ directory with Sphinx
sphinx:
configuration: source/conf.py
Expand All @@ -14,6 +20,5 @@ formats: all

# Optionally set the version of Python and requirements required to build your docs
python:
version: 3.7
install:
- requirements: requirements.txt
60 changes: 0 additions & 60 deletions .travis.yml

This file was deleted.

4 changes: 2 additions & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
sphinx>=1.9.0
sphinx>=5.0
sphinx_rtd_theme
sphinxcontrib-bibtex<2.0.0
sphinxcontrib-bibtex
6 changes: 3 additions & 3 deletions source/capturing/capturing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,16 @@ Capturing
If this is the first time you are using photogrammetry software, read the following chapter on how to take good photos for your project.

**Basics**
------
----------

- Your scene/object should be well lit.
- Avoid shadows, reflections, and transparent objects.
- Take the photos in diffuse or indirect lighting, such as on an overcast day (outdoor) or using multiple light sources (indoor).
- Don´t use the flash setting on the camera.
- Don't use the flash setting on the camera.
- Do not change the focal length/zoom while shooting. Use a fixed focal length lens if possible.
- Try to take pictures from all angles.
- Avoid moving objects in the scene or background.
- If taking pictures using a rotating rig, make sure to use a plain color background with no distiguishable features.
- If taking pictures using a rotating rig, make sure to use a plain color background with no distinguishable features.
- The object of interest should always fill most of the image.
- Take images with a side overlap of 60% minimum and frontal overlap of 80% minimum.
- For each shot, move to a new position (or rotate the object).
Expand Down
1 change: 1 addition & 0 deletions source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
# extensions coming with Sphinx (named 'sphinx.ext.*') or your custom
# ones.
extensions = ['sphinx.ext.autodoc', 'sphinx.ext.autosectionlabel', 'sphinx_rtd_theme', 'sphinxcontrib.bibtex']
bibtex_bibfiles = ['refs.bib']
sphinxVersion = sphinx.version_info
if(sphinxVersion[0] <= 1 and sphinxVersion[1] <= 8) :
extensions.append('sphinx.ext.pngmath')
Expand Down
2 changes: 1 addition & 1 deletion source/feature-documentation/cmd/photogrammetry.rst
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
``meshroom_batch (formerly meshroom_photogrammetry)``
===========================
=====================================================

Launch the full photogrammetry or panorama HDR pipeline.

Expand Down
7 changes: 7 additions & 0 deletions source/feature-documentation/core/nodes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,13 @@ These allow the progress and performance of the process to be monitored.
API
+++

You can create custom nodes in python and make them available in Meshroom using the ``MESHROOM_NODES_PATH`` environment variable.

In a standard precompiled version of Meshroom, you can also directly add custom nodes in ``lib/meshroom/nodes``.
If the nodes are placed in a custom folder there should be a Python module (an ``__init__.py`` file is needed) in the folder for the nodes to be recognized by Meshroom, .

To add a new node, you need to create a Python class that inherits from ``desc.Node`` or ``desc.CommandLineNode``.

Naming
######

Expand Down
Loading