Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare "noninteractive" environment variable globally in Dockerfile #1020

Merged

Conversation

ShadowMitia
Copy link
Contributor

No description provided.

@berquist
Copy link
Member

Is #1021 an accidental incomplete duplicate?

@ShadowMitia
Copy link
Contributor Author

Messed up my branches, sorry....

@berquist
Copy link
Member

My only concern is that this will be annoying for someone using this image as a dev container. Is there a way to set image build args for dev containers?

@ShadowMitia
Copy link
Contributor Author

ARGs are only available during builds, so it shouldn't interfere afterwards. And you can override them.

Copy link
Member

@berquist berquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, that slipped my mind. All seems good.

@berquist berquist merged commit 0754d4f into algorithm-archivists:main Oct 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants