Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Stack and Queue in Kotlin #1017

Closed
wants to merge 4 commits into from

Conversation

rdugue
Copy link

@rdugue rdugue commented Sep 26, 2023


name: Code submission
about: Add code or modify existing code in the Algorithm Archive

Code submission

Description

These are implementations of the stack ad queue data structures in Kotlin. I did both since they are fairly simple and this is one section in the book, even though the guideline say to do one algorithm at a time. If that is an issue I am more than happy to split them up into separate pull requests.

For Algorithm Archive Developers

  • There are no open PR's for this language implementation before this one
  • The Algorithm Archive can be built locally
  • The code conforms to the style guidelines
  • The Markdown file has been edited with appropriate line numbers

@Amaras
Copy link
Member

Amaras commented Sep 27, 2023

Hi!
Thank you for the PR and your interest for the AAA.
Unfortunately, we generally don't accept PRs from main branches, as they are bound to cause problems on merge, either for you or us.

The guideline indeed say to only implement one algorithm at a time, although it should say to only implement one chapter, so your PR is admissible on this count, don't worry.

I'm going to approve the CI run and we'll see if it compiles. In any case, I'd rather you opened a PR from the "stacks and queues" branch you seem to be using to develop.
Please just wait until the CI run is over before closing this PR, just so we're sure your code compiles (assuming we have Kotlin installed on that environment)

@Amaras
Copy link
Member

Amaras commented Sep 27, 2023

We don't have Kotlin installed on the CI environment, so... we'll have to do it manually.

I'll close this PR, please open a new PR from your development branch, and not your main.

@Amaras Amaras closed this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants