Skip to content

Commit

Permalink
Bump to 1.12.0 (#879)
Browse files Browse the repository at this point in the history
  • Loading branch information
damcou authored Oct 4, 2019
1 parent 325da0c commit 2cfb5a9
Show file tree
Hide file tree
Showing 13 changed files with 71 additions and 14 deletions.
6 changes: 5 additions & 1 deletion .php_cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
<?php

/** @var PhpCsFixer\Config $config */
$config = require __DIR__ . '/../../../.php_cs.dist';
if (isset($_SERVER['argv']) && $_SERVER['argv'][3]) {
$config = require dirname($_SERVER['argv'][3], 3) . '/.php_cs.dist';
} else {
$config = require __DIR__ . '/../../../.php_cs.dist';
}

$originalRules = $config->getRules();

Expand Down
27 changes: 27 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,32 @@
# CHANGE LOG

## 1.12.0

### FEATURES
- Algolia's facets backend rendering for Mysql Engine (#802)

### UPDATES
- The extension no longer supports Magento 2.1 **BC Break**
- B2B Feature : add condition for allow catalog browsing for enabling and add count check for list() (#820)
- Updated enabled logic to pull from the config helper class (#820)
- Add ACL for Algolia Search configuration section (#829)
- Remove the isQueueActive() check for the product plugin (#830)
- Update get product images (#823)
- Remove Circle CI 2.1 check (#849)
- Add facet query rules management + dashboard warnings (#844)
- Update video links in admin (#850)
- Add new support page with tabs (#845)
- Adjust the extension to be ready for upcoming MSI optional support that will come through another extension. (#841)
- Making PHPCompatibility assess no funky <7.1 PHP is used in our project
- Magento Cloud Development setup teardown (#860)
- Add type checking tool configuration (#861)
- Add notice when users have access to C&C Analytics but they haven't turned it on (#867)

### FIXES
- Add Store emulation for full category reindexing (#826)
- Category Product Updates for Update on Schedule (#819)
- Fix disabled autocomplete with active facet query rule) (#866)

## 1.11.3

### UPDATES
Expand Down
2 changes: 1 addition & 1 deletion Controller/Adminhtml/Landingpage/AbstractAction.php
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public function dispatch(\Magento\Framework\App\RequestInterface $request)
return parent::dispatch($request);
}

/** @return Algolia\AlgoliaSearch\Model\LandingPage */
/** @return \Algolia\AlgoliaSearch\Model\LandingPage */
protected function initLandingPage()
{
$landingPageId = (int) $this->getRequest()->getParam('id');
Expand Down
2 changes: 1 addition & 1 deletion Controller/Adminhtml/Query/AbstractAction.php
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public function dispatch(\Magento\Framework\App\RequestInterface $request)
return parent::dispatch($request);
}

/** @return Algolia\AlgoliaSearch\Model\Query */
/** @return \Algolia\AlgoliaSearch\Model\Query */
protected function initQuery()
{
$queryId = (int) $this->getRequest()->getParam('id');
Expand Down
2 changes: 1 addition & 1 deletion Controller/Adminhtml/Queue/AbstractAction.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ protected function _isAllowed()
return $this->_authorization->isAllowed('Algolia_AlgoliaSearch::manage');
}

/** @return Algolia\AlgoliaSearch\Model */
/** @return \Algolia\AlgoliaSearch\Model */
protected function initJob()
{
$jobId = (int) $this->getRequest()->getParam('id');
Expand Down
2 changes: 1 addition & 1 deletion Helper/Entity/Product/AttributeHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public function __construct(
/**
* Get attribute info by attribute code and entity type
*
* @param int|string|Mage\Eav\Model\Entity\Type $entityType
* @param int|string|\Magento\Eav\Model\Entity\Type $entityType
* @param string $attributeCode
*
* @return \Magento\Eav\Model\Entity\Attribute
Expand Down
5 changes: 3 additions & 2 deletions Model/Indexer/CategoryObserver.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ class CategoryObserver

/**
* CategoryObserver constructor.
*
* @param IndexerRegistry $indexerRegistry
* @param ConfigHelper $configHelper
* @param ResourceConnection $resource
Expand Down Expand Up @@ -53,7 +54,7 @@ public function afterSave(
CategoryResourceModel $result,
CategoryModel $category
) {
$categoryResource->addCommitCallback(function() use ($category) {
$categoryResource->addCommitCallback(function () use ($category) {
$collectionIds = [];
// To reduce the indexing operation for products, only update if these values have changed
if ($category->getOrigData('name') !== $category->getData('name')
Expand Down Expand Up @@ -92,7 +93,7 @@ public function afterDelete(
CategoryResourceModel $result,
CategoryModel $category
) {
$categoryResource->addCommitCallback(function() use ($category) {
$categoryResource->addCommitCallback(function () use ($category) {
// mview should be able to handle the changes for catalog_category_product relationship
if (!$this->indexer->isScheduled()) {
/* we are using products position because getProductCollection() doesn't use correct store */
Expand Down
2 changes: 1 addition & 1 deletion Model/Observer/CategoryMoveAfter.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

class CategoryMoveAfter implements ObserverInterface
{

/** @var IndexerRegistry */
private $indexerRegistry;

Expand Down Expand Up @@ -41,6 +40,7 @@ public function __construct(
* is not able to process the products that need updating.
*
* @param Observer $observer
*
* @return bool|void
*/
public function execute(Observer $observer)
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Algolia Search for Magento 2
==================

![Latest version](https://img.shields.io/badge/latest-1.11.3-green.svg)
![Latest version](https://img.shields.io/badge/latest-1.12.0-green.svg)
![Magento 2](https://img.shields.io/badge/Magento-%3E=2.1-blue.svg)
![Magento 2](https://img.shields.io/badge/Magento-%3C%202.3.2-blue.svg)
![PHP >= 5.6.5](https://img.shields.io/badge/PHP-%3E=5.6-green.svg)
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "Algolia Search integration for Magento 2",
"type": "magento2-module",
"license": ["MIT"],
"version": "1.11.3",
"version": "1.12.0",
"require": {
"php": "~5.6.5|~7.0|~7.1|~7.2|~7.3",
"magento/framework": "~100.1|~101.0|~102.0",
Expand Down
1 change: 1 addition & 0 deletions dev/cloud/teardown.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<?php

use Magento\Framework\App\Bootstrap;

require '/app/app/bootstrap.php';

$bootstrap = Bootstrap::create(BP, $_SERVER);
Expand Down
2 changes: 1 addition & 1 deletion etc/module.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
<module name="Algolia_AlgoliaSearch" setup_version="1.11.3">
<module name="Algolia_AlgoliaSearch" setup_version="1.12.0">
<sequence>
<module name="Magento_Theme"/>
<module name="Magento_Search" />
Expand Down
30 changes: 27 additions & 3 deletions phpstan.neon
Original file line number Diff line number Diff line change
@@ -1,8 +1,32 @@
parameters:
level: 0
excludes_analyse:
- %currentWorkingDirectory%/vendor/*
- %currentWorkingDirectory%/Test/*
paths:
- vendor/algolia/algoliasearch-magento-2/Adapter
- vendor/algolia/algoliasearch-magento-2/Api
- vendor/algolia/algoliasearch-magento-2/Block
- vendor/algolia/algoliasearch-magento-2/Controller
- vendor/algolia/algoliasearch-magento-2/DataProvider
- vendor/algolia/algoliasearch-magento-2/Exception
- vendor/algolia/algoliasearch-magento-2/Factory
- vendor/algolia/algoliasearch-magento-2/Helper
- vendor/algolia/algoliasearch-magento-2/Model
- vendor/algolia/algoliasearch-magento-2/Plugin
- vendor/algolia/algoliasearch-magento-2/Setup
- vendor/algolia/algoliasearch-magento-2/Test
- vendor/algolia/algoliasearch-magento-2/Ui
- vendor/algolia/algoliasearch-magento-2/ViewModel
- vendor/algolia/algoliasearch-magento-2/registration.php
ignoreErrors:
- '#(class|type) Magento\\\S*Factory#i'
- '#(class|type) Algolia\\\S*Factory#i'
- '#Call to static method getObjectManager\(\) on an unknown class Magento\\TestFramework\\Helper\\Bootstrap.#'
- '#Access to an undefined property Algolia\\AlgoliaSearch\\Plugin\\BackendFilterRendererPlugin::\$storeManager.#'
- '#Method Algolia\\AlgoliaSearch\\Model\\Layer\\Filter\\Price::prepareData\(\) invoked with 3 parameters, 2 required.#'
- '#Method Algolia\\AlgoliaSearch\\Model\\Layer\\Filter\\Decimal::prepareData\(\) invoked with 3 parameters, 2 required.#'
- '#Parameter \$clientFactory of method Algolia\\AlgoliaSearch\\Helper\\AlgoliaHelper::__construct\(\) has invalid typehint type AlgoliaSearch\\ClientFactory.#'
- '#Return typehint of method Algolia\\AlgoliaSearch\\Controller\\Adminhtml\\Queue\\AbstractAction::initJob\(\) has invalid type Algolia\\AlgoliaSearch\\Model.#'
- '#Access to an undefined property Algolia\\AlgoliaSearch\\Controller\\Adminhtml\\Query\\Save::\$imageUploader.#'
- '#Undefined variable: \$data#'
- '#Access to an undefined property Algolia\\AlgoliaSearch\\Block\\Navigation\\Renderer\\SliderRenderer::\$filter.#'
- '#Access to an undefined property Algolia\\AlgoliaSearch\\Block\\Navigation\\Renderer\\DefaultRenderer::\$filter.#'
- '#Access to an undefined property Algolia\\AlgoliaSearch\\Block\\Navigation\\Renderer\\CategoryRenderer::\$filter.#'

0 comments on commit 2cfb5a9

Please sign in to comment.