Make sure values supplied to HomeKit are within range

alexryd · Aug 1, 2021 · 0ec02ec · 0ec02ec
1 parent fca38ce
commit 0ec02ec
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 2 deletions.
diff --git a/abilities/battery.js b/abilities/battery.js
@@ -25,7 +25,7 @@ module.exports = homebridge => {
     }
 
     get level() {
-      return this.device[this._levelProperty]
+      return Math.min(Math.max(this.device[this._levelProperty], 0), 100)
     }
 
     get chargingState() {

diff --git a/abilities/humidity-sensor.js b/abilities/humidity-sensor.js
@@ -16,6 +16,10 @@ module.exports = homebridge => {
         humidityProperty
       )
     }
+
+    _valueToHomeKit(value) {
+      return Math.min(Math.max(value, 0), 100)
+    }
   }
 
   return HumiditySensorAbility

diff --git a/abilities/light-sensor.js b/abilities/light-sensor.js
@@ -30,6 +30,10 @@ module.exports = homebridge => {
 
       return service
     }
+
+    _valueToHomeKit(value) {
+      return Math.min(Math.max(value, 0.0001), 500000)
+    }
   }
 
   return LightSensorAbility

diff --git a/abilities/power-meter.js b/abilities/power-meter.js
@@ -31,7 +31,10 @@ module.exports = homebridge => {
     }
 
     get consumption() {
-      return this.device[this._consumptionProperty]
+      return Math.min(
+        Math.max(this.device[this._consumptionProperty], 0),
+        65535
+      )
     }
 
     get electricCurrent() {

diff --git a/abilities/temperature-sensor.js b/abilities/temperature-sensor.js
@@ -27,6 +27,10 @@ module.exports = homebridge => {
 
       return service
     }
+
+    _valueToHomeKit(value) {
+      return Math.min(Math.max(value, -270), 100)
+    }
   }
 
   return TemperatureSensorAbility