Merge pull request #100 from alexpdev/Fixes_#96

updated changelog and fixed coverage gaps

CHANGELOG.md

@@ -1,5 +1,14 @@
 # TorrentFile
 
+## Version 0.6.13
+
+- Fixed bug that created a torrent file with no name.
+- Fixed bug that would error if cli path was listed after announce urls
+- Added full unicode support.
+- Added Unittests for new features and bug fixes
+
+---------------------
+
 ## Version 0.6.11
 
 - Fixed bug that occured during recheck when file of 0 length is included.

docs/changelog/index.html

@@ -306,6 +306,13 @@
     </label>
     <ul class="md-nav__list" data-md-component="toc" data-md-scrollfix>
 
+        <li class="md-nav__item">
+  <a href="#version-0613" class="md-nav__link">
+    Version 0.6.13
+  </a>
+
+</li>
+
         <li class="md-nav__item">
   <a href="#version-0611" class="md-nav__link">
     Version 0.6.11
@@ -580,6 +587,13 @@
     </label>
     <ul class="md-nav__list" data-md-component="toc" data-md-scrollfix>
 
+        <li class="md-nav__item">
+  <a href="#version-0613" class="md-nav__link">
+    Version 0.6.13
+  </a>
+
+</li>
+
         <li class="md-nav__item">
   <a href="#version-0611" class="md-nav__link">
     Version 0.6.11
@@ -809,6 +823,14 @@
 
 
 <h1 id="torrentfile">TorrentFile</h1>
+<h2 id="version-0613">Version 0.6.13</h2>
+<ul>
+<li>Fixed bug that created a torrent file with no name.</li>
+<li>Fixed bug that would error if cli path was listed after announce urls</li>
+<li>Added full unicode support.</li>
+<li>Added Unittests for new features and bug fixes</li>
+</ul>
+<hr />
 <h2 id="version-0611">Version 0.6.11</h2>
 <ul>
 <li>Fixed bug that occured during recheck when file of 0 length is included.</li>

site/changelog.md

@@ -1,5 +1,14 @@
 # TorrentFile
 
+## Version 0.6.13
+
+- Fixed bug that created a torrent file with no name.
+- Fixed bug that would error if cli path was listed after announce urls
+- Added full unicode support.
+- Added Unittests for new features and bug fixes
+
+---------------------
+
 ## Version 0.6.11
 
 - Fixed bug that occured during recheck when file of 0 length is included.

tests/test_cli.py

@@ -438,3 +438,35 @@ def test_cli_announce_path(dir2, flag):
     sys.argv = args
     main()
     assert os.path.exists(str(dir2) + ".torrent")
+
+
+@pytest.mark.parametrize("version", ["1", "2", "3"])
+def test_cli_unicode_path(version):
+    """
+    Test creating a new torrent file with unicode characters.
+    """
+    text = "丂七万丈三上下丌不与丏丑丒专且丕世丗丘丙业丛东丝丠両丢丣两严丩个丫丬中丮丯"
+    parent = os.path.dirname(__file__)
+    dest = os.path.join(parent, text)
+    with open(dest, "wb") as tempfile:
+        l = 0
+        out = text
+        while l < 1 << 18:
+            tempfile.write((out + "\n").encode("utf-8"))
+            l += len(out)
+            out += out
+    args = [
+        "torrentfile",
+        "create",
+        "--private",
+        "-a",
+        "https://tracker1.org",
+        "https://tracker2.org",
+        "--meta-version",
+        version,
+        dest,
+    ]
+    sys.argv = args
+    main()
+    assert os.path.exists(dest)
+    rmpath(dest)

torrentfile/cli.py

@@ -146,7 +146,6 @@ def execute(args=None):
             args = sys.argv[1:]
         else:
             args = ["-h"]
-
     parser = ArgumentParser(
         "torrentfile",
         description="""
@@ -456,6 +455,10 @@ def execute(args=None):
 
     info_parser.set_defaults(func=info_command)
 
+    for i, arg in enumerate(args):
+        if hasattr(arg, "decode"):
+            args[i] = args[i].decode("utf-8")  # pragma: nocover
+
     args = parser.parse_args(args)
     if args.debug:
         torrentfile.add_handler()

torrentfile/utils.py

@@ -165,6 +165,8 @@ def filelist_total(pathstring: str) -> os.PathLike:
     MissingPathError
         File could not be found.
     """
+    if hasattr(pathstring, "decode"):
+        pathstring = pathstring.decode("utf-8")  # pragma: nocover
     if os.path.exists(pathstring):
         path = Path(pathstring)
         return _filelist_total(path)