fix verify password

alexferl · Oct 9, 2023 · 119eced · 119eced
1 parent fe10869
commit 119eced
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/util/password.go b/util/password.go
@@ -1,6 +1,8 @@
 package util
 
 import (
+	"errors"
+
 	"github.com/matthewhartstonge/argon2"
 )
 
@@ -15,10 +17,14 @@ func HashPassword(password []byte) (string, error) {
 }
 
 func VerifyPassword(password []byte, encoded []byte) error {
-	_, err := argon2.VerifyEncoded(encoded, password)
+	b, err := argon2.VerifyEncoded(encoded, password)
 	if err != nil {
 		return err
 	}
 
+	if !b {
+		return errors.New("mismatch")
+	}
+
 	return nil
 }
diff --git a/util/password_test.go b/util/password_test.go
@@ -14,3 +14,12 @@ func TestPassword(t *testing.T) {
 	err = VerifyPassword([]byte(enc), []byte(pwd))
 	assert.NoError(t, err)
 }
+
+func TestWrongPassword(t *testing.T) {
+	pwd := "s3cret"
+	enc, err := HashPassword([]byte(pwd))
+	assert.NoError(t, err)
+
+	err = VerifyPassword([]byte(enc), []byte("wrong"))
+	assert.Error(t, err)
+}