Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pyproject): add check-dist to ensure we ship all the needed files #595

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

Psycojoker
Copy link
Collaborator

I wanted to use check-manifest at first but it doesn't support pyproject.toml
yet so I've switch to check-dist which seems to do the job.

I'm not 100% convinced by it (it doesn't take into account the exclude
directive of hatch and you need to use a custom config to tell him to ignore
some files) but it should do the trick.

Like that we'll avoid error like releasing aleph-message without including "py.typed" file.

@hoh
Copy link
Member

hoh commented Aug 28, 2024

Thanks ! Should this be added to other repositories ?

@Psycojoker
Copy link
Collaborator Author

Thanks! Should this be added to other repositories?

Yes, that's the idea, same for other tools like pyproject-fmt, yamlix etc ... so we can spend less time on all of that.

@Psycojoker Psycojoker merged commit fbe9588 into pyproject Aug 28, 2024
4 checks passed
@Psycojoker Psycojoker deleted the lp-check-sdist branch August 28, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants