Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALEPH-7 project modernization: migrate project to python 3.12, hatch, pyproject.toml, upgrade dependencies, migrate to latest pytezos and add a bunch of other improvements and some documentation improvement. #574

Merged
merged 14 commits into from
Oct 2, 2024

Conversation

Psycojoker
Copy link
Collaborator

@Psycojoker Psycojoker commented Jul 9, 2024

Content of this PR (for now):

  • migrate to hatch and pyproject.toml
  • modify the workflows so they match the ones of the others projects
  • add instructions on how to run tests outside of nix/docker
  • on ci add a code quality job
  • disabled nix CI jobs because they just don't work anymore and it's not a priority right now

I suggest to read this PR commit by commit.

Split with another small PR #584

@Psycojoker Psycojoker force-pushed the pyproject branch 15 times, most recently from ca7bad1 to d40c1f5 Compare July 11, 2024 00:44
@Psycojoker Psycojoker changed the title Draft: migrate project to hatch and pyproject.toml and add a bunch of other improvements and some documentation improvment. migrate project to hatch and pyproject.toml and add a bunch of other improvements and some documentation improvment. Jul 11, 2024
@Psycojoker
Copy link
Collaborator Author

Ok, this PR should FINALLY be good, I've fixed a lot of small things and tried to move as close as possible to other projects (like the python SDK) to uniformise things.

There still might be weird things in the github workflows but some of them come from the old workflow or from the python SDK ones. I think we can refine those later if needed.

@hoh
Copy link
Member

hoh commented Jul 15, 2024

See my fixes in another PR based on this branch, and the annoying requirement to rebase on main 🙄

@Psycojoker Psycojoker force-pushed the pyproject branch 10 times, most recently from 54e40ec to 6f07856 Compare July 17, 2024 12:48
@Psycojoker Psycojoker changed the title project modernization: migrate project to python 3.12, hatch, pyproject.toml, upgrade dependencies, migrate to latest pytezos and add a bunch of other improvements and some documentation improvement. ALEPH-7 project modernization: migrate project to python 3.12, hatch, pyproject.toml, upgrade dependencies, migrate to latest pytezos and add a bunch of other improvements and some documentation improvement. Aug 30, 2024
@Psycojoker Psycojoker force-pushed the pyproject branch 4 times, most recently from 7226cdf to ceb4bd3 Compare September 19, 2024 09:28
@Psycojoker Psycojoker marked this pull request as ready for review September 19, 2024 09:29
Psycojoker and others added 5 commits October 1, 2024 19:03
…ydantic view them

In summary:

* pydantic except an explicit Literal[stuff] type
* mypy consider than an Enum.attribute IS a Literal
* thus mypy thinks that Literal[Enum.attribute] makes no sens at all
* but pydantic doesn't think that Enum.attribute is actually a litteral

We should probably upgrade to pydantic 2.*
* feat: update the version of our fork of pytezos

* Update pyproject.toml

Co-authored-by: Hugo Herter <[email protected]>

---------

Co-authored-by: Hugo Herter <[email protected]>
@hoh hoh merged commit 2676f8d into main Oct 2, 2024
4 checks passed
@Psycojoker Psycojoker deleted the pyproject branch October 2, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants