Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new EVM chains #717

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Conversation

nesitor
Copy link
Member

@nesitor nesitor commented Nov 1, 2024

Related Jira tickets : ALEPH-279

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.
  • Documentation has been updated regarding these changes.

Changes

Changed the aleph_message dependency to use the last version with new EVM definitions.

How to test

Deploy a VM using one of the new ones and check that should work as usually, like with "CHAIN": "POL".

Notes

This PR should be merged before at the deployment time.

@nesitor nesitor self-assigned this Nov 1, 2024
@nesitor nesitor changed the title Feature: Implement new EVM chains. Implement new EVM chains. Nov 1, 2024
@nesitor nesitor changed the title Implement new EVM chains. Implement new EVM chains Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.64%. Comparing base (089ccef) to head (7aefc5a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #717   +/-   ##
=======================================
  Coverage   62.64%   62.64%           
=======================================
  Files          69       69           
  Lines        6131     6131           
  Branches      490      490           
=======================================
  Hits         3841     3841           
  Misses       2146     2146           
  Partials      144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nesitor nesitor force-pushed the andres-feature-implement_new_evm_chains branch from 34ec062 to 7aefc5a Compare November 4, 2024 15:43
@nesitor nesitor merged commit 5acbdef into main Nov 4, 2024
22 checks passed
@nesitor nesitor deleted the andres-feature-implement_new_evm_chains branch November 4, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants