Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Sentry reporting didn't have release information #712

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

olethanh
Copy link
Collaborator

Solution : Add the release number to sentry init according to the Sentry documentation
https://docs.sentry.io/platforms/python/configuration/releases/

Related ClickUp, GitHub or Jira tickets : ALEPH-124

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.
  • Documentation has been updated regarding these changes.

Solution : Add the release number to sentry init according
to the Sentry documentation
https://docs.sentry.io/platforms/python/configuration/releases/
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.59%. Comparing base (123a4d8) to head (d1831b3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/aleph/vm/orchestrator/cli.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #712   +/-   ##
=======================================
  Coverage   62.59%   62.59%           
=======================================
  Files          69       69           
  Lines        6138     6138           
  Branches      491      491           
=======================================
  Hits         3842     3842           
  Misses       2152     2152           
  Partials      144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Psycojoker Psycojoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Psycojoker Psycojoker merged commit 7a2d6cc into main Oct 23, 2024
21 of 22 checks passed
@Psycojoker Psycojoker deleted the ol-aleph-124-sentry-version branch October 23, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants