Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI workflow for Droplet test #691

Merged
merged 7 commits into from
Sep 17, 2024
Merged

Improve CI workflow for Droplet test #691

merged 7 commits into from
Sep 17, 2024

Conversation

olethanh
Copy link
Collaborator

@olethanh olethanh commented Sep 4, 2024

  • Only calculate the IP once.
  • Do not include the configuration inside the Debian package but modify it directly inside the droplet.

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • [N/A] An LLM was used to review the new code and look for simplifications.
  • [N/A] New classes and functions contain docstrings explaining what they provide.
  • [of course] All new code is covered by relevant tests.
  • Documentation has been updated regarding these changes.

@hoh
Copy link
Member

hoh commented Sep 9, 2024

Tests on droplets were cancelled, restarted them 😉

@hoh
Copy link
Member

hoh commented Sep 9, 2024

image

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.19%. Comparing base (fefb30d) to head (01de28f).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #691   +/-   ##
=======================================
  Coverage   62.19%   62.19%           
=======================================
  Files          69       69           
  Lines        6074     6074           
  Branches      641      641           
=======================================
  Hits         3778     3778           
  Misses       2144     2144           
  Partials      152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoh hoh merged commit 3233e6e into main Sep 17, 2024
22 checks passed
@hoh hoh deleted the ol-ci-droplet-enh branch September 17, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants