Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix msgTypes + Add sort_by/sort_order args to MessageFilter/PostFilter #104

Merged
merged 5 commits into from
Feb 20, 2024
Merged

Fix msgTypes + Add sort_by/sort_order args to MessageFilter/PostFilter #104

merged 5 commits into from
Feb 20, 2024

Conversation

philogicae
Copy link
Member

@philogicae philogicae commented Feb 19, 2024 •
edited
Loading

Found issues:

  • Missing sort_by/sort_order filters: issue 95 on SDK
  • message_types passed as arg to MessageFilter breaks if nb elements > 1

Proposed solution:

  • Modified MessageFilter/PostFilter + Added SortBy/SortOrder enums
  • Fix typo on msgType -> msgTypes
  • Also requires merging of PR on PyAleph repo

@hoh

This was referenced Feb 19, 2024
Merged
Open
MHHukiewitz
MHHukiewitz previously approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@MHHukiewitz MHHukiewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.Thank you for the contribution! Also, good finds on msgTypes and enum_as_str 👍

@philogicae
Copy link
Member Author

Fixed the isort test failing

MHHukiewitz
MHHukiewitz requested changes Feb 19, 2024
View reviewed changes
src/aleph/sdk/utils.py Outdated Show resolved Hide resolved
@MHHukiewitz MHHukiewitz merged commit f60cedc into aleph-im:main Feb 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MHHukiewitz MHHukiewitz MHHukiewitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philogicae @MHHukiewitz