CI/CD: Code Quality Checks (#83)

* fix code quality with ruff

* add code-quality workflow

* Unify code-quality.yml into tests.yml

* fix imports

.github/workflows/tests.yml

@@ -2,11 +2,9 @@ name: Tests
 
 on:
   push:
-    branches:
-      - "*"
   pull_request:
     branches:
-      - "*"
+      - main
 
 jobs:
   build:
@@ -27,10 +25,18 @@ jobs:
       - name: Cache the image on GitHub's repository
         run: docker tag aleph-message:${GITHUB_REF##*/} docker.pkg.github.com/$GITHUB_REPOSITORY/aleph-message-build-cache && docker push docker.pkg.github.com/$GITHUB_REPOSITORY/aleph-message-build-cache || true
 
+      - name: Test with black in the Docker image
+        run: |
+          docker run aleph-message:${GITHUB_REF##*/} black --check aleph_message
+
+      - name: Test with ruff in the Docker image
+        run: |
+          docker run aleph-message:${GITHUB_REF##*/} ruff aleph_message
+
       - name: Pytest in the Docker image
         run: |
           docker run aleph-message:${GITHUB_REF##*/} pytest -vv --cov aleph_message
 
       - name: MyPy in the Docker image
         run: |
-          docker run aleph-message:${GITHUB_REF##*/} mypy aleph_message --ignore-missing-imports --check-untyped-defs
+          docker run aleph-message:${GITHUB_REF##*/} mypy aleph_message --install-types --non-interactive --check-untyped-defs --ignore-missing-imports

Dockerfile

@@ -4,3 +4,4 @@ RUN pip install pytest requests types-requests pytest-cov mypy twine typing-exte
 COPY . /opt/aleph-message
 WORKDIR /opt/aleph-message
 RUN pip install -e .
+RUN pip install mypy ruff black

aleph_message/models/__init__.py

@@ -13,7 +13,7 @@
 from .base import Chain, HashType, MessageType
 from .execution.instance import InstanceContent
 from .execution.program import ProgramContent
-from .execution.base import PaymentType, MachineType, Payment
+from .execution.base import PaymentType, MachineType, Payment  # noqa
 from .item_hash import ItemHash, ItemType
 
 

aleph_message/models/execution/environment.py

@@ -81,10 +81,10 @@ class CpuProperties(HashableModel):
     class Config:
         extra = Extra.forbid
 
-class HypervisorType(str, Enum):
-    qemu = 'qemu'
-    firecracker = 'firecracker'
 
+class HypervisorType(str, Enum):
+    qemu = "qemu"
+    firecracker = "firecracker"
 
 
 class FunctionEnvironment(HashableModel):

aleph_message/models/execution/program.py

@@ -1,8 +1,8 @@
 from __future__ import annotations
 
-from typing import Literal, Optional, Union
+from typing import Literal, Optional
 
-from pydantic import Field, validator
+from pydantic import Field
 
 from ..abstract import HashableModel
 from ..item_hash import ItemHash

aleph_message/models/execution/volume.py

@@ -2,9 +2,9 @@
 
 from abc import ABC, abstractmethod
 from enum import Enum
-from typing import Literal, Optional, Type, Union
+from typing import Literal, Optional, Union
 
-from pydantic import ConstrainedInt, Extra, conint
+from pydantic import ConstrainedInt, Extra
 
 from ...utils import Gigabytes, gigabyte_to_mebibyte
 from ..abstract import HashableModel

aleph_message/tests/test_models.py

@@ -3,7 +3,6 @@
 from os import listdir
 from os.path import isdir, join
 from pathlib import Path
-from typing import Dict
 
 import pytest
 import requests
@@ -20,7 +19,6 @@
     MessageType,
     PostContent,
     PostMessage,
-    ProgramContent,
     ProgramMessage,
     add_item_content_and_hash,
     create_message_from_file,