Refactor: instance list to handle PAYG instance #215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed to retrieve llama text: POST 504: 504 Gateway Time-outThe server didn't respond in time. |
|
@1yam can you rebase this branch when you have some time plz? It conflicts with master now |
Psycojoker
requested changes
Jun 27, 2024
| except ClientResponseError: | ||
| return message.item_hash, "Not available (yet)" | ||
|
|
||
|
|
||
| async def _show_instances(messages: List[InstanceMessage]): | ||
| async def _show_instances(messages: List[InstanceMessage], node_list): |
There was a problem hiding this comment.
Can you add some typing to node_list plz?
| return await resp.json() | ||
|
|
||
|
|
||
| async def _get_ipv6_address(message: InstanceMessage, node_list) -> Tuple[str, str]: |
There was a problem hiding this comment.
Can you add some typing to node_list plz?
The project still used `setup.py` and `setup.cfg`. This branch: 1. Migrates to pyproject.toml and `hatch`. 2. Updates workflows accordingly. 3. Changes README from reStructuredText to the easier Markdown. 4. Updates dependencies.
Solution: Use `importlib.metadata.version` instead.
Issue: Previously, users were unable to create PAYG instances from the CLI using a CRN. Solution: Implemented a prompt to ask users if they want to create a PAYG instance, displaying a list of compatible CRNs after an asynchronous fetching of the information. Co-authored-by: Hugo Herter <[email protected]> Co-authored-by: Antonyjin <[email protected]>
|
Clean PR : Here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
aleph instance listonly handles the Hold method.Solution:
Check the payment type and fetch api_url and ipv6 from
/about/executions/list.Changes: