Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aleph instance delete to use async #186

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Fix aleph instance delete to use async #186

merged 1 commit into from
Dec 7, 2023

Conversation

MHHukiewitz
Copy link
Member

No description provided.

@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Dec 7, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023 •
edited by MHHukiewitz
Loading

  • The diff includes a change to the delete function, which is an asynchronous function now. This could potentially impact other parts of the codebase that interact with this function.
  • There's also a change in the forget method call where it now accepts an additional argument reason. This could affect how data is stored and managed in the system.

But it is just a simple async fix.

@MHHukiewitz MHHukiewitz added BLUE This PR is simple and straightforward. and removed BLACK This PR has critical implications and must be reviewed by a senior engineer. labels Dec 7, 2023
1yam
1yam approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@1yam 1yam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MHHukiewitz MHHukiewitz merged commit 018895b into master Dec 7, 2023
7 checks passed
@MHHukiewitz MHHukiewitz deleted the mhh-fix-create-instance branch December 7, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1yam 1yam 1yam approved these changes

Assignees
No one assigned
Labels
BLUE This PR is simple and straightforward.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MHHukiewitz @1yam