Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Instance #178

Merged
merged 7 commits into from
Dec 5, 2023
Merged

Create Instance #178

merged 7 commits into from
Dec 5, 2023

Conversation

MHHukiewitz
Copy link
Member

Adds two new functions:
-aleph instance create: Creates a new instance
-aleph instance delete: Deletes/Forgets an instance

@MHHukiewitz MHHukiewitz marked this pull request as ready for review November 30, 2023 14:49
@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Nov 30, 2023
Copy link

github-actions bot commented Nov 30, 2023

This PR introduces a new command instance with multiple subcommands for managing instances on the Aleph.im network, such as creating and deleting instances.

  • Adding a new file src/aleph_client/commands/instance.py with the implementation of the instance command and its subcommands.
  • Updating src/aleph_client/conf.py to include new default values for rootfs settings.
  • Adding help strings for the new command and its subcommands in src/aleph_client/commands/help_strings.py.
  • Refactoring volume parsing in src/aleph_client/commands/utils.py

The complexity of this PR is rated as 'BLACK' due to the extensive changes it introduces, which may have a high potential for introducing bugs or requiring deep understanding of the project architecture. Only experienced developers should review this PR.

Has been downgraded to RED, due to the previously mistaken assumption that creating volumes is a new feature in this PR

@MHHukiewitz MHHukiewitz added RED This PR is complex and may require more time to review. and removed BLACK This PR has critical implications and must be reviewed by a senior engineer. labels Nov 30, 2023
@MHHukiewitz MHHukiewitz requested a review from nesitor November 30, 2023 14:57
Copy link
Collaborator

@1yam 1yam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MHHukiewitz MHHukiewitz merged commit f268215 into master Dec 5, 2023
6 checks passed
@MHHukiewitz MHHukiewitz deleted the mhh-create-instance branch December 5, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RED This PR is complex and may require more time to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants